dash: Show move cursor on app icon dnd to dash

Previously, the 'copy' drag and drop cursor was displayed when dragging
an application icon to the dash (which adds the app to favorites),
but the operation is really a move, so ensure the 'move'
dnd cursor is used.

Closes: https://gitlab.gnome.org/GNOME/gnome-shell/-/issues/7819
Part-of: <https://gitlab.gnome.org/GNOME/gnome-shell/-/merge_requests/3453>

diff --git a/js/ui/dash.js b/js/ui/dash.js
index 086bc8275fd09762749b8bd457a25dba1fafb681..585f340636f7b697d5462140bf904070f17b6c11 100644 (file)
--- a/js/ui/dash.js
+++ b/js/ui/dash.js
@@ -935,12 +935,7 @@ export const Dash = GObject.registerClass({
         if (!this._dragPlaceholder)
             return DND.DragMotionResult.NO_DROP;
 
-        let srcIsFavorite = favPos !== -1;
-
-        if (srcIsFavorite)
-            return DND.DragMotionResult.MOVE_DROP;
-
-        return DND.DragMotionResult.COPY_DROP;
+        return DND.DragMotionResult.MOVE_DROP;
     }
 
     // Draggable target interface